Fix empty item in explorer after clicking on Collapse Folders action while editing new file/folder#96853
Merged
isidorn merged 1 commit intomicrosoft:masterfrom May 4, 2020
Merged
Conversation
Collaborator
|
Tried it out and it looks great. Also awesome that you removed the timeout! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #96846
this.tree.domFocusin thecollapseAllmethod only if we are editing the explorer to cancel it.cancelEditing(defaulttrue) parameter to therefreshmethod, the only place we don't want to cancel edit while refreshing is in thesetEditablemethod. With this change the timeout in explorerViewer is not necessary.Tested this locally on Ubuntu 18.04 on #96846, #96198, #96566