Allow the inline diff editor to be centered.#97311
Merged
isidorn merged 1 commit intomicrosoft:masterfrom May 11, 2020
petevdp:allow-centered-inline-diff-editor
Merged
Allow the inline diff editor to be centered.#97311isidorn merged 1 commit intomicrosoft:masterfrom petevdp:allow-centered-inline-diff-editor
isidorn merged 1 commit intomicrosoft:masterfrom
petevdp:allow-centered-inline-diff-editor
Conversation
Collaborator
|
Thank you very much for this PR. I tested the changes and it works great. Thus merging in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #97165
The issue here was that while
DiffEditorInputis an instance ofSideBySideEditorInput, it still allows for inline editing based on the config valuediffEditor.renderSideBySide.My proposed fix involves handling that case and centering appropriately, as well as calling
Layout.centerEditorLayoutwhen the configuration changes since centering behaviour is now contingent on the above configuration option.One thing to note is that this will also cause the layout to be centered/uncentered when
workbench.editor.centeredLayoutAutoResizechanges, since we're also using this config option to determine centering behaviour. I think the fact that we weren't already updating based on config changes counts as a bug as well.To test these changes use the test case outlined in the issue(#97165)