Add property default show context value proeprty#97920
Merged
JacksonKearl merged 4 commits intomicrosoft:masterfrom May 27, 2020
Merged
Add property default show context value proeprty#97920JacksonKearl merged 4 commits intomicrosoft:masterfrom
JacksonKearl merged 4 commits intomicrosoft:masterfrom
Conversation
|
|
Contributor
|
I wonder how this should interact with |
Contributor
Author
|
Makes sense to me. If someone wants to have the old |
defaultShowContextValue takes precedence over reusePriorSearchConfiguration
JacksonKearl
approved these changes
May 27, 2020
Contributor
JacksonKearl
left a comment
JacksonKearl
left a comment
There was a problem hiding this comment.
Looks good, I made one small change.
|
|
||
| let config = { ...defaultConfig, ...priorConfig, ...existingData.config }; | ||
|
|
||
| if (defaultShowContextValue !== null && defaultShowContextValue !== undefined) { |
Contributor
There was a problem hiding this comment.
Changed this so that setting the property to 0 has an effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes (implements?) #97915
Add the
search.searchEditor.defaultShowContextValuesettings option to configure the default value for the number of context lines.To test add
to settings, a new search editor should now show 2 lines of context.
reusePriorSearchConfigurationshould take precedence though, so with settings likenew search editor windows should show the previously set number of context lines.