Make Neo keyboard layout (layer 4) arrow keys work in explorer view#98269
Merged
joaomoreno merged 6 commits intomicrosoft:masterfrom May 29, 2020
Conversation
joaomoreno
requested changes
May 26, 2020
| .filter(this.keyboardNavigationEventFilter || (() => true)) | ||
| .filter(() => this.automaticKeyboardNavigation || this.triggered) | ||
| .filter(e => this.keyboardNavigationDelegate.mightProducePrintableCharacter(e) || ((this.pattern.length > 0 || this.triggered) && ((e.keyCode === KeyCode.Escape || e.keyCode === KeyCode.Backspace) && !e.altKey && !e.ctrlKey && !e.metaKey) || (e.keyCode === KeyCode.Backspace && (isMacintosh ? (e.altKey && !e.metaKey) : e.ctrlKey) && !e.shiftKey))) | ||
| .filter(e => this.keyboardNavigationDelegate.mightProducePrintableCharacter(e) && !(e.keyCode === KeyCode.DownArrow || e.keyCode === KeyCode.UpArrow || e.keyCode === KeyCode.LeftArrow || e.keyCode === KeyCode.RightArrow) || ((this.pattern.length > 0 || this.triggered) && ((e.keyCode === KeyCode.Escape || e.keyCode === KeyCode.Backspace) && !e.altKey && !e.ctrlKey && !e.metaKey) || (e.keyCode === KeyCode.Backspace && (isMacintosh ? (e.altKey && !e.metaKey) : e.ctrlKey) && !e.shiftKey))) |
Member
There was a problem hiding this comment.
I'm not a huge fan of having && in the same level as || as it might appear ambiguous to unsuspecting readers. Please make it explicit by wrapping what needs to be wrapped in parenthesis.
Contributor
Author
There was a problem hiding this comment.
Sure, I made a commit for that. Thanks for your review!
…fix/make-neo-keyboard-layout-layer4-arrow-keys-work-in-explorer-view Merge master from upstream in order to pass the Azure pipeline run for macOS.
…fix/make-neo-keyboard-layout-layer4-arrow-keys-work-in-explorer-view Merging upstream master again because checks failed for Windows, Linux and macOS.
…fix/make-neo-keyboard-layout-layer4-arrow-keys-work-in-explorer-view Merge upstream master again in order to be up to date and to pass all tests.
Contributor
Author
|
@joaomoreno : After I have added the parantheses (which didn't change the code logic), some checks failed. But these failures don't seem to be caused by my commits. I already tried merging upstream master several times but the checks keep failing (although the failures vary). What can I do? |
…fix/make-neo-keyboard-layout-layer4-arrow-keys-work-in-explorer-view Getting up to date.
Member
|
All good, thanks for this! 🍻 |
Contributor
Author
|
Thank you for merging! 👍🏻 |
MaxGyver83
deleted the
bugfix/make-neo-keyboard-layout-layer4-arrow-keys-work-in-explorer-view
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #97946.
The Neo2 keyboard layout (and others) have special keys (arrow keys, page up/down, tab, return, escape, ...) on layer 4. For example:
AltGr+D=DownArrow. This bugfix makes the explorer view behave as expected if such a layer 4 down arrow (or any other arrow) is pressed.For testing:
setxkbmap de neo_qwertyAltGr+EorDfor going up and downAltGr+SorFfor folding/unfolding folders