Proposal: Allow TS Server to be spawned with --inspect-brk#98340
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom May 26, 2020
Merged
Proposal: Allow TS Server to be spawned with --inspect-brk#98340mjbvz merged 1 commit intomicrosoft:masterfrom
mjbvz merged 1 commit intomicrosoft:masterfrom
Conversation
Collaborator
|
This looks good to me. Thanks for taking a look. The name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve found this to be very useful while developing TS Server features, as a lot of work happens immediately after VS Code spawns TS Server, which doesn’t allow enough time to attach a debugger unless the process pauses. I plan on also updating my vscode-tsserver-debug extension to leverage this if merged.
While this change would make my work (and likely the work of others working on TS Server) much easier, it should be considered with some caution, since it means that TS Server cannot start in the presence of a
TSS_DEBUG_BRKenvironment variable until a debugger attaches and unpauses its execution. If by some very strange means (e.g., malicious extension code?) a user unknowingly ended up with this environment variable set, JS/TS language service operations wouldn’t work and it could be difficult to diagnose. So I’m open to feedback on other ways to accomplish this, depending on the level of concern from the team.@mjbvz for thoughts, whenever you have a minute.