Update typescript.code-snippets#98521
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom May 27, 2020
Jack-Works:patch-1
Merged
Update typescript.code-snippets#98521mjbvz merged 1 commit intomicrosoft:masterfrom Jack-Works:patch-1
mjbvz merged 1 commit intomicrosoft:masterfrom
Jack-Works:patch-1
Conversation
Collaborator
|
The for await addition looks good but I don't think we should change the |
Contributor
Author
|
Hmm how to use it to rethrow exception? It provides a string as default |
Collaborator
|
Good point. This looks like an improvement then. Thanks, this will be in the next VS Code insiders build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
throw "$1"tothrow new Error("$1"). Throw a string is a bad practice because it will drop the execution stack.for await of