pkg/stringid: remove deprecated IsShortID, ValidateID#48705
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Oct 21, 2024
Merged
pkg/stringid: remove deprecated IsShortID, ValidateID#48705AkihiroSuda merged 1 commit intomoby:masterfrom
AkihiroSuda merged 1 commit intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
impact/changelog
impact/deprecation
area/go-sdk
impact/go-sdk
thaJeztah
force-pushed
the
stringid_cleanups_step2
branch
from
f113c08 to
83f17b0
Compare
austinvazquez
approved these changes
Oct 20, 2024
AkihiroSuda
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsShortIDwas deprecated in 2100a70ValidateIDwas deprecated in e19e6cfBoth are part of 27.0, so we can remove these.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)