Skip to content

From 28.0.0, don't migrate per-endpoint sysctls#48746

Merged
thaJeztah merged 1 commit intomoby:masterfrom
robmry:48282_disable_sysctl_migration_in_api1.48
Oct 24, 2024
Merged

From 28.0.0, don't migrate per-endpoint sysctls#48746
thaJeztah merged 1 commit intomoby:masterfrom
robmry:48282_disable_sysctl_migration_in_api1.48

Conversation

@robmry
Copy link
Contributor

@robmry robmry commented Oct 24, 2024

- What I did

Now we know the API version for release 28.0.0, disable migration of per-endpoint sysctls from that version.

- How I did it

Re-added checks that were removed until 28.0.0's API version was known, in commit 17adc14

- How to verify it

Unit test.

- Description for the changelog

- In API version 1.48 and later, settings for `eth0` in `--sysctl` options will no longer be automatically migrated to the network endpoint. For example, on the command line in a docker run command, `--network mynet --sysctl net.ipv4.conf.eth0.log_martians=1` will be rejected. Instead, you must use `--network name=mynet,driver-opt=com.docker.network.endpoint.sysctls=net.ipv4.conf.IFNAME.log_martians=1`

Re-add checks that were removed until 28.0.0's API version was
known, in commit 17adc14

Signed-off-by: Rob Murray <rob.murray@docker.com>
@robmry robmry added area/networking Networking impact/changelog kind/refactor PR's that refactor, or clean-up code labels Oct 24, 2024
@robmry robmry added this to the 28.0.0 milestone Oct 24, 2024
@robmry robmry self-assigned this Oct 24, 2024
@robmry robmry requested a review from thaJeztah October 24, 2024 11:21
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 032721f into moby:master Oct 24, 2024
@robmry robmry deleted the 48282_disable_sysctl_migration_in_api1.48 branch October 25, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/networking Networking impact/changelog kind/refactor PR's that refactor, or clean-up code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop migrating per-interface sysctls from '--sysctl'

2 participants