daemon/export: Stop when context is canceled #49265
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jan 13, 2025
Merged
Conversation
vvoland
added
status/2-code-review
area/daemon
thaJeztah
reviewed
Jan 13, 2025
vvoland
force-pushed
the
export-ctx-cancellation
branch
from
099762b to
e4608fe
Compare
vvoland
commented
Jan 13, 2025
Close archive when context is done - this makes the cancellation actually stop the export instead of continuing it regardless if the client still expects the data. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
export-ctx-cancellation
branch
from
e4608fe to
5a6a980
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close archive when context is done - this makes the cancellation actually stop the export instead of continuing it regardless if the client still expects the data.
- How to verify it
Before this PR, the export would finish and
container exportevent would be emitted.After this PR, the event is not emitted and the dockerd logs show that operation ended with "canceled" error.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)