client: ImagePullResponse: don't panic without reader#51159
Merged
thaJeztah merged 1 commit intomoby:masterfrom Oct 10, 2025
Merged
client: ImagePullResponse: don't panic without reader#51159thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
When stubbing a client for tests, and there's no reader set, we just return an io.EOF, instead of panic. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
Member
Author
|
Oh! I marked this as "validate only" - don't think we need all of CI to run for this change 😅 (so that I can re-vendor after this in the CLI) |
vvoland
approved these changes
Oct 10, 2025
This was referenced Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stubbing a client for tests, and there's no reader set, we just return an io.EOF, instead of panic.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)