Skip to content

JAVA-4320 fix server selection flaky test #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
strogiyotec merged 7 commits into from
Jan 3, 2026
Merged

JAVA-4320 fix server selection flaky test #1847

strogiyotec merged 7 commits into from
Jan 3, 2026

Conversation

@strogiyotec
Copy link
Contributor

@strogiyotec strogiyotec commented Dec 2, 2025 •
edited
Loading

JAVA-4320
1. increase the number of operations to 1000 as in NodeJs
2. increase the deviation to 15% as in NodeJs

Increased local threshold to 3 seconds

@strogiyotec strogiyotec requested a review from a team as a code owner December 2, 2025 23:13
@strogiyotec strogiyotec requested a review from nhachicha December 2, 2025 23:13
@stIncMale
Copy link
Member

stIncMale commented Dec 3, 2025

This PR suggests we should change the corresponding specification prose test https://github.com/mongodb/specifications/blob/master/source/server-selection/server-selection-tests.md#prose-test. I don't think Node should have just silently deviated from the spec.

@vbabanin vbabanin self-requested a review December 4, 2025 02:52
@strogiyotec
Copy link
Contributor Author

strogiyotec commented Dec 9, 2025

This PR suggests we should change the corresponding specification prose test https://github.com/mongodb/specifications/blob/master/source/server-selection/server-selection-tests.md#prose-test. I don't think Node should have just silently deviated from the spec.

@stIncMale thanks for the feedback, I noticed that dotnet driver doesn't experience flakiness with 10% deviation, the only difference I saw is the threshold value

  1. dotnet uses 1seconds
  2. specification mentioned localThresholdMS=30000

So I updated the PR to have 10% deviation and increased threshold
I also created a patch for evergreen that ran this test 300 times , no failed tests were observed

stIncMale
stIncMale reviewed Dec 10, 2025
View reviewed changes
Copy link
Member

@stIncMale stIncMale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@strogiyotec strogiyotec merged commit cece170 into mongodb:main Jan 3, 2026
56 checks passed
nhachicha pushed a commit that referenced this pull request Jan 19, 2026
@strogiyotec @nhachicha
JAVA-4320 fix server selection flaky test (#1847)
e8a70c8 
* JAVA-4320 fix server selection flaky test

* set server selection threshold to 3seconds

* serverSelection flaky test, update comments

* server selection , update threshold to 30_000 MS

---------

Co-authored-by: Almas Abdrazak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stIncMale stIncMale stIncMale approved these changes

@vbabanin vbabanin vbabanin approved these changes

@nhachicha nhachicha Awaiting requested review from nhachicha nhachicha is a code owner automatically assigned from mongodb/dbx-java

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@strogiyotec @stIncMale @vbabanin