Promise.value and Guarantee.value when T == Void#1096
Merged
mxcl merged 9 commits intomxcl:masterfrom Sep 25, 2019
RomanPodymov:master
Merged
Promise.value and Guarantee.value when T == Void#1096mxcl merged 9 commits intomxcl:masterfrom RomanPodymov:master
mxcl merged 9 commits intomxcl:masterfrom
RomanPodymov:master
Conversation
Owner
|
Thanks, this is a good addition. Can we get a test that verifies that this is not ambiguous for any version of Swift we support? ie: func test() {
// tests no amiguity
let a = Promise<Void>.value
let b = Promise<Void>.value(Void())
}Thanks. |
Collaborator
Author
Hello @mxcl |
Owner
|
Marvelous thank you for your contribution! |
caldrian
pushed a commit
to codestruction-eu/PromiseKit
that referenced
this pull request
Nov 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Thank you for PromiseKit.
I see that
Resolverhasfunc fulfill_()forT == Void. I would propose to add similar functions forPromiseandGuarantee.Also, declared
func Promise.value()asstaticbecausePromiseisfinal.