Don't lose attributes of method parameters#12
Merged
ncave merged 1 commit intoncave:service_slimfrom Aug 29, 2022
Merged
Conversation
Owner
|
Not a problem @alfonsogarciacaro, that's what this branch is for. |
ncave
pushed a commit
that referenced
this pull request
Nov 14, 2022
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Nov 14, 2022
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Nov 30, 2022
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Nov 30, 2022
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Feb 24, 2023
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Feb 24, 2023
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Apr 15, 2023
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Apr 15, 2023
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Oct 23, 2023
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Dec 8, 2023
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Dec 8, 2023
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Nov 16, 2024
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Nov 22, 2024
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Jan 15, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Jan 15, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Oct 14, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Oct 14, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Oct 16, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Oct 16, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Oct 25, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Oct 25, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Nov 11, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Nov 11, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Nov 11, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
pushed a commit
that referenced
this pull request
Nov 21, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
ncave
added a commit
that referenced
this pull request
Nov 21, 2025
Temporary fix, remove when upstream dotnet#13786 is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dotnet#13786
Good news is this was not too complicated to fix. The problem was there is a function called
GetParamAttribsthat actually discards the param attributes 🤣 (instead it gets info that's usually expressed with attributes in F# likebyref, default value, etc). However, the fix required touching several other places where this function is called. I've tried to make the minimal changes I needed to fix the issue, but I'm pretty sure the F# team would prefer to fix this in a more consistent way (e.g. properties still have the same problem). Anyways, I've also sent them these changes for reference.Unfortunately, this is a stopper to release Fable 4 as it breaks current apps, so I've already updated Fable with a FCS build containing the fix. I think we can merge this single commit in
service_slimfor now and when the issue is fixed indotnet/fsharp(hopefully soon) we can just revert this PR before syncing. What do you think @ncave?