Skip to content

Conversation

@bsipocz
Copy link
Contributor

@bsipocz bsipocz commented Jun 18, 2024

Minor update to redirect action after its move

@bsipocz
Copy link
Contributor Author

bsipocz commented Jun 18, 2024

The failing labels actions feels a tiny bit weird, is there maybe a nicer user experience solution?

(E.g. automatic label-needed label on PRs without any labels, thus a reviewer can filter and review those before code review/merge instead of triggering failing CI notifications)?

@rossbar
Copy link
Contributor

rossbar commented Jun 19, 2024

The failing labels actions feels a tiny bit weird, is there maybe a nicer user experience solution?

I agree that this is probably not the best UX for contributors - it basically guarantees that contributors who don't have triage rights will always be confronted with the red x when they open a PR, regardless of the state of tests/CI.

Thanks for the feedback @bsipocz - I'm going to add this to the agenda for the next community meeting!

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI complaints unrelated, thanks @bsipocz !

@rossbar rossbar merged commit 82529f8 into networkx:main Jun 19, 2024
@jarrodmillman jarrodmillman added this to the 3.4 milestone Jun 19, 2024
@bsipocz bsipocz deleted the CI_moved_action branch June 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants