Merged
Conversation
Signed-off-by: Sandro Mesterheide <sandro.mesterheide@extern.publicplan.de>
Contributor
|
Thanks! I wonder how we can document that this type is only available with some version of Nextcloud |
Contributor
Author
|
Fair point. Do you mean like adding the server min version to package.json? |
Contributor
|
I don't think there is a mechanism to check that unfortunately. What we certainly can do is add a js doc for the property stating what version of Nextcloud this is available. |
Contributor
Author
|
I was not sure about the enum and ES5 transpilation, but it seems to work out just fine in my tooling: |
Signed-off-by: Sandro Mesterheide <sandro.mesterheide@extern.publicplan.de>
susnux
reviewed
Jun 19, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
approved these changes
Jun 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In accordance with nextcloud/server#34132