feat: add assembling status to UploadPicker#1530
Merged
Conversation
Bundle ReportChanges will increase total bundle size by 1.33kB (0.17%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
5a25133 to
e29c6d3
Compare
Contributor
|
@skjnldsv Awesome! But it still not works for me. Reproducer:
Expected: Progressbar shows upload progress and assembling status until all files are not uploaded and assembled nextcloud-upload-2024-12-19_10.09.23.mp4 |
Contributor
Author
|
Will add tests and fix that use case, nice catch! :) |
Contributor
|
@skjnldsv as an option - we can merge current PR as is and fix my edge case in separate PR |
susnux
reviewed
Jan 21, 2025
susnux
reviewed
Jan 21, 2025
e29c6d3 to
2c9fd0d
Compare
susnux
approved these changes
Feb 25, 2025
Contributor
|
@skjnldsv rebased + added a commit with the missing tests and fixed the issue (the job queue was empty after upload as we did not add the assembling to the queue so it was reset = whole status reset) |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
…mbling Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2c9fd0d to
5d01576
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Koc here is my take on this.
I think adding some text to the right isn't the right approach.
Now we make sure we don't have any ongoing upload that are NOT assembling
If all is left is assembling tasks, we show the status.
Closes #1458