feat(button): Added option to not have label on New button#1831
Merged
susnux merged 2 commits intonextcloud-libraries:mainfrom Aug 6, 2025
Merged
feat(button): Added option to not have label on New button#1831susnux merged 2 commits intonextcloud-libraries:mainfrom
susnux merged 2 commits intonextcloud-libraries:mainfrom
Conversation
6 tasks
Signed-off-by: Jonas Stene <jonas@stene.li>
2786810 to
0318ca0
Compare
susnux
reviewed
Aug 4, 2025
susnux
approved these changes
Aug 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1831 +/- ##
==========================================
+ Coverage 28.58% 36.05% +7.46%
==========================================
Files 14 20 +6
Lines 1543 1742 +199
Branches 49 83 +34
==========================================
+ Hits 441 628 +187
- Misses 1102 1114 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skjnldsv
approved these changes
Aug 6, 2025
69073ab to
21058b4
Compare
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Jonas Stene <jonas@stene.li>
21058b4 to
2ac95f5
Compare
Merged
Contributor
|
Note for myself: backport to next is not needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: nextcloud/server#53991
Summary
To be able to resolve nextcloud/server#53991 regarding breakpoints in the files app I have added a prop
noLabelon theUploadPickercomponent to disable the label on breakpoint changes.This change is required for this PR in nextcloud/server: nextcloud/server#54235
With label:

Without label:

Checklist