fix(uploader): queue is not empty when everything is skipped#2002
Merged
fix(uploader): queue is not empty when everything is skipped#2002
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2002 +/- ##
==========================================
+ Coverage 36.16% 39.69% +3.53%
==========================================
Files 20 20
Lines 1745 1746 +1
Branches 83 91 +8
==========================================
+ Hits 631 693 +62
+ Misses 1114 1053 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
susnux
approved these changes
Jan 7, 2026
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
elzody
approved these changes
Jan 7, 2026
Contributor
Author
|
/backport to next |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batchUploadwraps all the files to upload into a metaUploadinstance and adds it to the uploading queue for:This queue is emptied when the job queue is finished.
However, when all the files to upload are skipped, there is no job in the job queue, so it never finishes and never cleans the upload queue. The meta-upload exists in the upload queue but does not have a corresponding job in the job queue (it is not a real upload).
A fix: as this is an artificial meta upload - also manually remove it from the queue.
Alternatives: