fix: Use OCP\IAppConfig instead of OCP\IConfig to prevent config error#713
fix: Use OCP\IAppConfig instead of OCP\IConfig to prevent config error#713
Conversation
kyteinsky
left a comment
There was a problem hiding this comment.
thanks!
It seems this one instance was not converted to IAppConfig which resulted in the conflict.
|
We need a fix for this fix. Will open a PR for this. |
|
/backport to stable32 |
|
It's better to do it with two backports so as not to lose the |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
When using the CLI to register a daemon
I'm getting:
I think the problem only occurs when I already had a previous daemon installed which I uninstalled first.
This PR does not only resolve the problem but also removes the use of a deprecated NC function.