fix(discovery): check for db cached folder quota during discovery for some items. #8307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
requested changes
Jun 5, 2025
Collaborator
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
this is missing automated tests changes that would show up what is the intended benefit from this change
camilasan
force-pushed
the
bugfix/addquotatodb
branch
from
6da1973 to
a2615d3
Compare
camilasan
force-pushed
the
bugfix/addquotatodb
branch
5 times, most recently
from
11a757b to
7a22bc3
Compare
nilsding
requested changes
Jul 31, 2025
mgallien
requested changes
Jul 31, 2025
Collaborator
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
see my inline comments
camilasan
force-pushed
the
bugfix/addquotatodb
branch
2 times, most recently
from
e1f15a3 to
84e7166
Compare
mgallien
requested changes
Aug 1, 2025
mgallien
force-pushed
the
bugfix/addquotatodb
branch
2 times, most recently
from
d15bf52 to
2700789
Compare
mgallien
approved these changes
Aug 1, 2025
mgallien
force-pushed
the
bugfix/addquotatodb
branch
from
2700789 to
9e32168
Compare
nilsding
approved these changes
Aug 1, 2025
…tadata table. Signed-off-by: Camila Ayres <[email protected]>
…base. Signed-off-by: Camila Ayres <[email protected]>
… some items. Signed-off-by: Camila Ayres <[email protected]>
…nfoQuota quota. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…to FolderQuota struct. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
rename FileInfo::Etags::Validate to FileInfo::Etags::Keep Signed-off-by: Matthieu Gallien <[email protected]>
rename FileInfo::Etags to FileInfo::EtagsAction to avoid any future possibility that we would want to use this name for something else Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/addquotatodb
branch
from
9e32168 to
5842f88
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8307.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Collaborator
|
/backport to stable-3.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8278.