fix(get/file): avoid failing to download files under 20 MiB #8333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
approved these changes
Jun 3, 2025
nilsding
approved these changes
Jun 3, 2025
mgallien
force-pushed
the
bugfix/avoidFailingSmallDownloadForDecompressedSafetyCheck
branch
from
37725cf to
f45cfa9
Compare
mgallien
force-pushed
the
bugfix/avoidFailingSmallDownloadForDecompressedSafetyCheck
branch
from
f45cfa9 to
fa99f68
Compare
if a file that uncompresses to a file size under 10 MiB, Qt will allow it for files with an higher size, they must not have higher compression ratio than what Qt network stack expect https://doc.qt.io/qt-6/qnetworkrequest.html#setDecompressedSafetyCheckThreshold we will use a 2 times bigger threshold Close #7470 Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/avoidFailingSmallDownloadForDecompressedSafetyCheck
branch
from
fa99f68 to
1144ac4
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8333.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
mgallien
deleted the
bugfix/avoidFailingSmallDownloadForDecompressedSafetyCheck
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a file that uncompresses to a file size under 10 MiB, Qt will allow it
for files with an higher size, they must not have higher compression ratio than what Qt network stack expect
https://doc.qt.io/qt-6/qnetworkrequest.html#setDecompressedSafetyCheckThreshold
we will use a 2 times bigger threshold
Close #7470