Skip to content

Make http error messages user friendly #8394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgallien merged 2 commits into from
Aug 5, 2025
Merged

Make http error messages user friendly #8394

mgallien merged 2 commits into from
Aug 5, 2025

Conversation

@camilasan
Copy link
Member

@camilasan camilasan commented Jun 24, 2025

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 24, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
Image 1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

@camilasan camilasan force-pushed the bugfix/errormessage branch 3 times, most recently from 3505059 to 8fef650 Compare August 4, 2025 11:39
@camilasan camilasan added this to the 3.17.0 milestone Aug 4, 2025
@camilasan camilasan marked this pull request as ready for review August 4, 2025 11:39
@camilasan camilasan requested a review from kra-mo August 4, 2025 11:45
@camilasan camilasan changed the title Improve http error messages. Make http error messages user friendly Aug 4, 2025
@camilasan camilasan force-pushed the bugfix/errormessage branch 2 times, most recently from 9908a49 to b1311ad Compare August 4, 2025 12:14
mgallien
mgallien requested changes Aug 4, 2025
View reviewed changes
@camilasan camilasan force-pushed the bugfix/errormessage branch from b1311ad to 6ba43f1 Compare August 4, 2025 15:01
@camilasan
Copy link
Member Author

camilasan commented Aug 4, 2025

/backport to stable-3.17

kra-mo
kra-mo approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are still a bit technical, but definitely an improvement :)

For better error messages, you'd want to use other heuristics too anyway, but definitely out of scope here.

@camilasan camilasan force-pushed the bugfix/errormessage branch 3 times, most recently from f5c811e to b081670 Compare August 5, 2025 07:22
kra-mo
kra-mo reviewed Aug 5, 2025
View reviewed changes
@camilasan camilasan force-pushed the bugfix/errormessage branch from b081670 to 593e004 Compare August 5, 2025 07:59
@mgallien mgallien force-pushed the bugfix/errormessage branch from 593e004 to 6bf7edf Compare August 5, 2025 08:05
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8394.zip

SHA256 checksum: 1a3739da04d3c69a573936ca8981b5c9592f4287f0de18818567db1af52f2e8a

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
Image 3.6% Coverage on New Code (required ≥ 80%)
Image 2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

@mgallien mgallien merged commit a023132 into master Aug 5, 2025
16 of 17 checks passed
@mgallien mgallien deleted the bugfix/errormessage branch August 5, 2025 09:21
@backportbot backportbot bot mentioned this pull request Aug 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kra-mo kra-mo kra-mo approved these changes

@mgallien mgallien mgallien approved these changes

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@camilasan @mgallien @kra-mo