-
Notifications
You must be signed in to change notification settings - Fork 910
Additional Localizations in macOS File Provider #8514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am still working on the enablement of relevant localizations within the Xcode project so localizations arriving from Transifex in the strings catalog actually are considered. It will be ready and pushed on some minutes. |
a40da70 to
77b366c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds additional localization support to the macOS File Provider by extending language support and making accessibility descriptions localizable. The changes focus on improving internationalization for users of the Nextcloud desktop client's macOS shell integration.
- Added support for over 100 additional language codes in the Xcode project configuration
- Updated hardcoded accessibility descriptions to use localized strings for better i18n support
- Converted share type descriptions from hardcoded English text to localizable strings
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| project.pbxproj | Extended the list of supported languages/locales in the Xcode project configuration |
| ShareOptionsView.swift | Made accessibility descriptions for delete and cancel button icons localizable |
| LockViewController.swift | Updated accessibility descriptions for document and checkmark icons to use localized strings |
| NKShare+Extensions.swift | Converted all share type icons and descriptions from hardcoded English to localizable strings |
...l_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Locking/LockViewController.swift
Show resolved
Hide resolved
|
/backport to stable-3.17 |
77b366c to
c2fa677
Compare
…ider. Signed-off-by: Iva Horn <[email protected]>
…ansifex. Signed-off-by: Iva Horn <[email protected]>
c2fa677 to
7e54bac
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8514.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
The backport to # Switch to the target branch and update it
git checkout stable-3.17
git pull origin stable-3.17
# Create the new backport branch
git checkout -b backport/8514/stable-3.17
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 58d389d6 7e54bace
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8514/stable-3.17Error: Failed to check for changes with origin/stable-3.17: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable-3.17 |



This is a follow up pull request to #8507 which was already merged by accident.