Skip to content

Conversation

@i2h3
Copy link
Collaborator

@i2h3 i2h3 commented Aug 1, 2025

This is a follow up pull request to #8507 which was already merged by accident.

@i2h3 i2h3 added this to the 3.17.0 milestone Aug 1, 2025
@i2h3 i2h3 self-assigned this Aug 1, 2025
@i2h3 i2h3 requested review from camilasan and mgallien as code owners August 1, 2025 08:29
@i2h3 i2h3 requested a review from nilsding as a code owner August 1, 2025 08:29
@i2h3 i2h3 mentioned this pull request Aug 1, 2025
@i2h3 i2h3 marked this pull request as draft August 1, 2025 08:34
@i2h3
Copy link
Collaborator Author

i2h3 commented Aug 1, 2025

I am still working on the enablement of relevant localizations within the Xcode project so localizations arriving from Transifex in the strings catalog actually are considered. It will be ready and pushed on some minutes.

@i2h3 i2h3 force-pushed the feature/file-provider-localization branch from a40da70 to 77b366c Compare August 1, 2025 09:47
@i2h3 i2h3 marked this pull request as ready for review August 1, 2025 09:48
@i2h3 i2h3 requested review from Copilot and removed request for camilasan August 1, 2025 09:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds additional localization support to the macOS File Provider by extending language support and making accessibility descriptions localizable. The changes focus on improving internationalization for users of the Nextcloud desktop client's macOS shell integration.

  • Added support for over 100 additional language codes in the Xcode project configuration
  • Updated hardcoded accessibility descriptions to use localized strings for better i18n support
  • Converted share type descriptions from hardcoded English text to localizable strings

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
project.pbxproj Extended the list of supported languages/locales in the Xcode project configuration
ShareOptionsView.swift Made accessibility descriptions for delete and cancel button icons localizable
LockViewController.swift Updated accessibility descriptions for document and checkmark icons to use localized strings
NKShare+Extensions.swift Converted all share type icons and descriptions from hardcoded English to localizable strings

@nilsding
Copy link
Member

nilsding commented Aug 1, 2025

/backport to stable-3.17

@i2h3 i2h3 force-pushed the feature/file-provider-localization branch from 77b366c to c2fa677 Compare August 1, 2025 11:10
@i2h3 i2h3 enabled auto-merge August 1, 2025 11:10
@i2h3 i2h3 force-pushed the feature/file-provider-localization branch from c2fa677 to 7e54bac Compare August 1, 2025 12:26
@github-actions
Copy link

github-actions bot commented Aug 1, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-8514.zip

SHA256 checksum: e12dca3e7318e3b8d42a23a79a344617878dc6f1054464107ae1958fe76de49b

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2025

@i2h3 i2h3 merged commit cf6bcaf into master Aug 1, 2025
18 checks passed
@i2h3 i2h3 deleted the feature/file-provider-localization branch August 1, 2025 12:59
@backportbot
Copy link

backportbot bot commented Aug 1, 2025

The backport to stable-3.17 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.17
git pull origin stable-3.17

# Create the new backport branch
git checkout -b backport/8514/stable-3.17

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 58d389d6 7e54bace

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8514/stable-3.17

Error: Failed to check for changes with origin/stable-3.17: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nilsding
Copy link
Member

nilsding commented Aug 1, 2025

/backport to stable-3.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants