fix(folder): use the remotePath for the sidebar display name #8562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable-3.17 |
mgallien
reviewed
Aug 12, 2025
mgallien
approved these changes
Aug 12, 2025
Signed-off-by: Jyrki Gadinger <[email protected]>
Using the short local folder name has some interesting side effects, such as ending up as being e.g. "C:\MySyncRoot" or "Desktop\MySyncRoot" due to it just removing the path to the current user's home directory. IMO using the remote path for the sidebar entry is more logical -- I don't care where I synced it to locally, I just want to know what my sync destination is. To improve future maintenance I moved the generation of the sidebar display name to a separate method, and added some quick unit tests. Signed-off-by: Jyrki Gadinger <[email protected]>
mgallien
force-pushed
the
bugfix/noid/shortcut-names
branch
from
e710604 to
91f8797
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8562.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the short local folder name has some interesting side effects, such as ending up as being e.g. "C:\MySyncRoot" or "Desktop\MySyncRoot" due to it just removing the path to the current user's home directory.
IMO using the remote path for the sidebar entry seems to be more logical, most of the times I only want to know what my sync destination is.
To improve future maintenance I moved the generation of the sidebar display name to a separate method, and added some quick unit tests.