fix(i18n): Use SI symbol for minute #8600
Conversation
rakekniven
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
I think there must be a space to be 100% correct...
| return QObject::tr("now"); | ||
| } else { | ||
| return QObject::tr("1m", "one minute after activity date and time"); | ||
| return QObject::tr("1min", "one minute after activity date and time"); |
There was a problem hiding this comment.
| return QObject::tr("1min", "one minute after activity date and time"); | |
| return QObject::tr("1 min", "one minute after activity date and time"); |
| } | ||
| } else { | ||
| return (QObject::tr("%nm", "delay in minutes after an activity", minutes)); | ||
| return (QObject::tr("%nmin", "delay in minutes after an activity", minutes)); |
There was a problem hiding this comment.
| return (QObject::tr("%nmin", "delay in minutes after an activity", minutes)); | |
| return (QObject::tr("%n min", "delay in minutes after an activity", minutes)); |
| earlyTS = earlyTS.addSecs(-6); | ||
| s = timeAgoInWords(earlyTS, laterTS ); | ||
| QCOMPARE(s, QLatin1String("1m")); | ||
| QCOMPARE(s, QLatin1String("1min")); |
There was a problem hiding this comment.
| QCOMPARE(s, QLatin1String("1min")); | |
| QCOMPARE(s, QLatin1String("1 min")); |
Do you have a reference for that change? All other time specifications do not have a space. Should I adjust that as well? |
I found this: https://www.nist.gov/pml/special-publication-811/nist-guide-si-chapter-7-rules-and-style-conventions-expressing-values#7.2
I guess so, yes |
|
@mgallien How to proceed here? Can we merge this here and add the space for all time specs in another PR? |
|
Following doc supports Simons message: https://commission.europa.eu/document/download/c45f5b70-2d0e-4da7-b181-b5fe3a16c4bb_en Chapter 7.20 |
rakekniven
force-pushed
the
rakekniven-patch-1
branch
from
b46f5ab to
8fa7d98
Compare
@rakekniven yes |
Discussed in forum. e .g. "5m" is not correct Corrrect form is "5min" See https://en.wikipedia.org/wiki/Minute for reference Signed-off-by: rakekniven <[email protected]>
Signed-off-by: rakekniven <[email protected]>
mgallien
force-pushed
the
rakekniven-patch-1
branch
from
8fa7d98 to
26c1bc6
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8600.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
I mean as I said it is technically not correct but I can remove my blocking so that you can proceed 👍 |
Discussed in forum (https://help.nextcloud.com/t/heist-1m-einen-monat-oder-eine-minute/230353).
e .g. "5m" is not correct
Corrrect form is "5min"
See https://en.wikipedia.org/wiki/Minute for reference