fix(quota): return unlimited quota if server query is invalid or file is in folder root. #8714
Conversation
camilasan
force-pushed
the
bugfix/quotadir
branch
3 times, most recently
from
5a0d793 to
96f636e
Compare
camilasan
force-pushed
the
bugfix/quotadir
branch
from
96f636e to
1d76893
Compare
nilsding
force-pushed
the
bugfix/quotadir
branch
from
1d76893 to
832c798
Compare
nilsding
requested review from
Aiiaiiio,
i2h3,
mgallien and
nilsding
as code owners
|
/backport to stable-4.0 |
| // therefore: parse the string as a double and cast it to i64 | ||
| auto ok = false; | ||
| auto quotaValue = static_cast<int64_t>(map.value(FolderQuota::usedBytesC).toDouble(&ok)); | ||
| result.folderQuota.bytesUsed = ok ? quotaValue : -1; |
There was a problem hiding this comment.
Since this pattern occurs at multiple places, I would consider a converter function toQuota() or similar.
… is in folder root. Signed-off-by: Camila Ayres <[email protected]> Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Camila Ayres <[email protected]> Signed-off-by: Jyrki Gadinger <[email protected]>
`processFileAnalyzeRemoteInfo` is only called iff `serverEntry.isValid` anyway Signed-off-by: Jyrki Gadinger <[email protected]>
`LsColJob::propertyMapToRemoteInfo` takes care of that too Signed-off-by: Jyrki Gadinger <[email protected]>
The server can respond with values like `2.58440798353E+12` instead of a plain number like `2584407983530`. `QVariant::toLongLong` does not recognise that as a valid number and returns `0` instead, breaking the sync for some. Also added a fallback value in case parsing the value as double doesn't work either. Fixes #8555 Signed-off-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/quotadir
branch
from
832c798 to
cd8601e
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8714.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
|
I just installed version 4.0.0-rc2 Windows from the beta update channel. The problem with checking the quota persists, the files are not uploaded to the server |
|
@corben-svg the rc2 was released before this change got merged We'll include this in 4.0.0, to test the change before the final 4.0 release you need to wait until tomorrow for the new daily build |
|
/backport to stable-4.0 |
|
I just installed the new version 4.0.1 for Windows. The quota verification error persists. #8555 problem has not been solved. Please reopen issue @nilsding @camilasan |
|
/backport to stable-3.17 |
|
@camilasan Hi! The error persists on the stable version 4.0.3. |
Possibly fix for #8555