Skip to content

Conversation

@i2h3
Copy link
Collaborator

@i2h3 i2h3 commented Sep 10, 2025

Successor to #8635 which I had to close due to a required branch renaming. The client now relies on UUIDs for the file provider domain identifiers but leaves already existing file provider domains in place with their current legacy identifiers which are based on the account identifiers. Also includes the implementation for the empty Finder modal for signing in. Also fixes an account error state cache invalidation.

@i2h3 i2h3 added this to the 3.18.0 milestone Sep 10, 2025
@i2h3 i2h3 self-assigned this Sep 10, 2025
@i2h3 i2h3 marked this pull request as draft September 11, 2025 07:43
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💻 Desktop Clients team Sep 11, 2025
@i2h3 i2h3 moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💻 Desktop Clients team Sep 11, 2025
@i2h3 i2h3 force-pushed the bugfix/8491-domain-uuids branch from d9ae1f7 to 2ba2b25 Compare September 11, 2025 08:57
@nilsding
Copy link
Member

/backport! 2ba2b25 to stable-3.17

@i2h3 i2h3 force-pushed the bugfix/8491-domain-uuids branch from 2ba2b25 to 979cca8 Compare September 12, 2025 13:28
@Rello Rello moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Sep 15, 2025
@i2h3 i2h3 force-pushed the bugfix/8491-domain-uuids branch from 18581f4 to 3752620 Compare September 15, 2025 08:57
@i2h3 i2h3 marked this pull request as ready for review September 15, 2025 10:36
@i2h3 i2h3 force-pushed the bugfix/8491-domain-uuids branch from 3752620 to b033fb9 Compare September 15, 2025 11:40
@i2h3 i2h3 requested a review from Copilot September 15, 2025 11:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements UUID-based file provider domain identifiers to replace legacy account-based identifiers, while maintaining backward compatibility for existing domains. It introduces authentication UI handling for unauthenticated file provider domains and includes account error state cache invalidation improvements.

Key changes:

  • Migration from account-based to UUID-based file provider domain identifiers
  • Addition of authentication modal UI for handling file provider authentication failures
  • Implementation of UUID mapping system in config files for domain identification

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/libsync/configfile.h & src/libsync/configfile.cpp Adds UUID mapping functions for file provider domains
src/gui/macOS/fileproviderdomainmanager_mac.mm Implements UUID generation and domain resolution logic
src/gui/macOS/fileproviderxpc_mac.mm Updates method names from extension to domain terminology
shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Authentication/ Adds authentication modal UI components
shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderDomainDefaults.swift Replaces config system with domain-specific defaults

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@i2h3 i2h3 force-pushed the bugfix/8491-domain-uuids branch from ed62ef3 to c36bc23 Compare September 15, 2025 12:11
@i2h3 i2h3 force-pushed the bugfix/8491-domain-uuids branch from c36bc23 to 930fbb9 Compare September 16, 2025 12:52
@i2h3 i2h3 force-pushed the bugfix/8491-domain-uuids branch from 930fbb9 to 613733d Compare September 17, 2025 06:15
@github-actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-8726.zip

Digest: sha256:a15e5afe429cd151e56f1a727286d0b9bc666d6ce400a17dcbc75865f473aabe

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
Image 0.0% Coverage on New Code (required ≥ 80%)
Image 90 New Code Smells (required ≤ 0)
Image D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

@i2h3 i2h3 merged commit ae7f671 into master Sep 17, 2025
17 of 19 checks passed
@i2h3 i2h3 deleted the bugfix/8491-domain-uuids branch September 17, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle Sign-in From Finder Use UUIDs for File Provider Domain Identifiers

4 participants