-
Notifications
You must be signed in to change notification settings - Fork 909
UUID File Provider Domains #8726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d9ae1f7 to
2ba2b25
Compare
|
/backport! 2ba2b25 to stable-3.17 |
2ba2b25 to
979cca8
Compare
18581f4 to
3752620
Compare
...ation/MacOSX/NextcloudIntegration/FileProviderUIExt/Authentication/Authentication.storyboard
Show resolved
Hide resolved
shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderDomainDefaults.swift
Outdated
Show resolved
Hide resolved
3752620 to
b033fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements UUID-based file provider domain identifiers to replace legacy account-based identifiers, while maintaining backward compatibility for existing domains. It introduces authentication UI handling for unauthenticated file provider domains and includes account error state cache invalidation improvements.
Key changes:
- Migration from account-based to UUID-based file provider domain identifiers
- Addition of authentication modal UI for handling file provider authentication failures
- Implementation of UUID mapping system in config files for domain identification
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/libsync/configfile.h & src/libsync/configfile.cpp |
Adds UUID mapping functions for file provider domains |
src/gui/macOS/fileproviderdomainmanager_mac.mm |
Implements UUID generation and domain resolution logic |
src/gui/macOS/fileproviderxpc_mac.mm |
Updates method names from extension to domain terminology |
shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Authentication/ |
Adds authentication modal UI components |
shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderDomainDefaults.swift |
Replaces config system with domain-specific defaults |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...n/MacOSX/NextcloudIntegration/FileProviderExt/Extensions/NSError+FileProviderErrorCode.swift
Show resolved
Hide resolved
shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderDomainDefaults.swift
Outdated
Show resolved
Hide resolved
ed62ef3 to
c36bc23
Compare
c36bc23 to
930fbb9
Compare
…ward compatibility. Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
…). Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
… of credentials. Signed-off-by: Iva Horn <[email protected]>
Signed-off-by: Iva Horn <[email protected]>
930fbb9 to
613733d
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8726.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|




Successor to #8635 which I had to close due to a required branch renaming. The client now relies on UUIDs for the file provider domain identifiers but leaves already existing file provider domains in place with their current legacy identifiers which are based on the account identifiers. Also includes the implementation for the empty Finder modal for signing in. Also fixes an account error state cache invalidation.