Skip to content

fix(log): Improve log messages for client status reporting #9052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nilsding merged 2 commits into from
Nov 13, 2025
Merged

fix(log): Improve log messages for client status reporting #9052

nilsding merged 2 commits into from
Nov 13, 2025

Conversation

@Rello
Copy link
Collaborator

@Rello Rello commented Nov 13, 2025 •
edited
Loading

2025-11-13 13:34:18:329 [ warning nextcloud.sync.clientstatusreportingdatabase /Volumes/builds/34964/macos-34964/src/libsync/clientstatusreportingdatabase.cpp:215 ]: Could not get last sent report timestamp from keyvalue table: ""

confusing log messages without context.

  • use consistent log naming for the feature "client status report" (which is the status that we send to security guard).
  • correct wrong log messages when error/no entry in the table was found
  • reduced warning do debug

@Rello Rello marked this pull request as ready for review November 13, 2025 08:42
@nilsding nilsding force-pushed the bugfix/clientStatusReportLogging branch from f5c1968 to dda2ee4 Compare November 13, 2025 10:49
@nilsding
Copy link
Member

nilsding commented Nov 13, 2025

/backport to stable-4.0

@nilsding nilsding added this to the 4.1.0 milestone Nov 13, 2025
@nilsding nilsding enabled auto-merge November 13, 2025 10:55
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-9052.zip

Digest: sha256:f2afc362ab0df325e9128bfc4cd25aba392f8c2f0b2b5f2c9f469e921f7b3d2e

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding nilsding merged commit 87d66a0 into master Nov 13, 2025
19 of 20 checks passed
@nilsding nilsding deleted the bugfix/clientStatusReportLogging branch November 13, 2025 11:25
@backportbot backportbot bot mentioned this pull request Nov 13, 2025
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 13, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
Image 31 New Code Smells (required ≤ 0)
Image E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Image Catch issues before they fail your Quality Gate with our IDE extension Image SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding approved these changes

@i2h3 i2h3 i2h3 approved these changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Rello @nilsding @i2h3