feat(developer): add IPreloadableNotifier to upgrade guide#13485
feat(developer): add IPreloadableNotifier to upgrade guide#13485
Conversation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
ChristophWurst
left a comment
There was a problem hiding this comment.
👍 on listing this in the upgrade guide so app devs can check their notifiers and modify them if needed
But this should also have a dedicated page, regardless of the 32 changes, with an example to demonstrate the purpose of the preload
|
That would then be https://github.com/nextcloud/notifications/blob/master/docs/notification-workflow.md Or we move all this over at some point. Since I hold a lightning Talk about this, I can take care of it when preparing that. |
|
Personally I would prefer to have this in the dev manual where we also cover the rest of OCP, so 👍 on moving it over :) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
☑️ Resolves
INotifier::preloadMany()to allow implementations to preload and cache data for many notifications at once server#54231🖼️ Screenshots