Conversation
susnux
force-pushed
the
feat/add-nextcloud-changelog
branch
from
c3c6d9a to
e76ccb3
Compare
|
/backport to stable29 |
susnux
force-pushed
the
feat/add-nextcloud-changelog
branch
from
e76ccb3 to
541a278
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
susnux
force-pushed
the
feat/add-nextcloud-changelog
branch
from
541a278 to
d1032fc
Compare
Pytal
left a comment
Pytal
left a comment
There was a problem hiding this comment.
Code looks good other than minor remarks, did not test
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><path d="M23.446 18l0.889-5.791h-5.557v-3.758c0-1.584 0.776-3.129 3.265-3.129h2.526v-4.93c0 0-2.292-0.391-4.484-0.391-4.576 0-7.567 2.774-7.567 7.795v4.414h-5.087v5.791h5.087v14h6.26v-14z" fill="currentColor" /></svg> | |||
There was a problem hiding this comment.
Setting an explicit width="32" height="32" may help prevent some visual bugs on svgs
| axios.delete(generateUrl('/apps/firstrunwizard/wizard')) | ||
| } | ||
| // Exposes open and close functions from the component | ||
| defineExpose({ open, close }) |
* Split `App.vue` into `App.vue` and `SlideShow.vue` * Add `WizardPage` as common base for all pages * Use `script setup` to reduce boiler plate code and better TypeScript support * Rename pages so the name makes sense Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This adds additional slides to the wizard for changes in the current Nextcloud Hub release and for sharing it with other users. Also modified the menu entry from "About" to "About & What's new". Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/add-nextcloud-changelog
branch
from
d1032fc to
dc4f0ba
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/add-nextcloud-changelog
branch
from
dc4f0ba to
32f3d46
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
4 participants
Current state: Waiting for real data to include.
App.vueintoApp.vueandSlideShow.vueWizardPageas common base for all pagesscript setupto reduce boiler plate code and better TypeScript support