Skip to content

Comments

A new message for upload Chunk file#3837

Merged
marinofaggiana merged 8 commits intomasterfrom
progressbar
Oct 24, 2025
Merged

A new message for upload Chunk file#3837
marinofaggiana merged 8 commits intomasterfrom
progressbar

Conversation

@marinofaggiana
Copy link
Member

@marinofaggiana marinofaggiana commented Oct 24, 2025 •
edited
Loading

Screenshot 2025-10-24 at 11 23 13 Simulator Screenshot - iPhone 17 - 2025-10-24 at 11 08 57 Simulator Screenshot - iPhone 17 - 2025-10-24 at 11 08 59 Simulator Screenshot - iPhone 17 - 2025-10-24 at 11 09 06

@marinofaggiana
code
71aba50 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
progress
228554c 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
code
cdab7ec 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@mpivchev
Copy link
Collaborator

mpivchev commented Oct 24, 2025 •
edited
Loading

Looks great!

You can change the strings to:
"Please wait, preparing file upload" to "Preparing file upload. Please wait..."
"Keep application active until upload is completed..."

What does the "Please wait... at the end" entail? It's saving to DB?

@mpivchev
Copy link
Collaborator

mpivchev commented Oct 24, 2025

image

Can you animate this rotation of the arrows? I think its possible, check SF Symbols app.

@mpivchev
Copy link
Collaborator

mpivchev commented Oct 24, 2025

image image

You can animate these as well. Check SF Symbols app.

@mpivchev
Copy link
Collaborator

mpivchev commented Oct 24, 2025

Finally, can we make it glassy or translucent?

@mpivchev
Copy link
Collaborator

mpivchev commented Oct 24, 2025

image

I think there should be a bit more space between the text and progress bar

mpivchev
mpivchev requested changes Oct 24, 2025
View reviewed changes
iOSClient/Networking/NCNetworking+Upload.swift Outdated
return results
}

func uploadChunkWithPresented(metadata: tableMetadata) async {
Copy link
Collaborator

@mpivchev mpivchev Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference between this and uploadChunkWithHud

Copy link
Member Author

@marinofaggiana marinofaggiana Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple it use HUD

@marinofaggiana marinofaggiana merged commit 4949d18 into master Oct 24, 2025
2 of 4 checks passed
@marinofaggiana marinofaggiana deleted the progressbar branch October 24, 2025 13:07
@marinofaggiana
Copy link
Member Author

marinofaggiana commented Oct 24, 2025

Looks great!

You can change the strings to: "Please wait, preparing file upload" to "Preparing file upload. Please wait..." "Keep application active until upload is completed..."

What does the "Please wait... at the end" entail? It's saving to DB?

please wait -> the server assemble the chunks and then he move it in the directory as single file.

@mpivchev
Copy link
Collaborator

mpivchev commented Oct 27, 2025

Looks great!
You can change the strings to: "Please wait, preparing file upload" to "Preparing file upload. Please wait..." "Keep application active until upload is completed..."
What does the "Please wait... at the end" entail? It's saving to DB?

please wait -> the server assemble the chunks and then he move it in the directory as single file.

Can you then write it as "Finalizing. Please wait..."

@mpivchev
Copy link
Collaborator

mpivchev commented Oct 27, 2025

Finally, can we make it glassy or translucent?

image I think there should be a bit more space between the text and progress bar

Any update on these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpivchev mpivchev mpivchev requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marinofaggiana @mpivchev