added X509_verify(cert, serverPubKey)

[marinofaggiana]

• added E2EE X509_verify

[alperozturk96]

I will compare with Android

[alperozturk96]

I created certificate from Android and tested on iOS, certificate verification working.

@marinofaggiana You can check my optional suggestion for code changes.

[alperozturk96]

This logic can be deduplicated for createNewE2EE and getPrivateKeyCipher.

Function:

private func verifyCertificate(_ account: String, _ publicKey: String) -> Bool {
  var result = false

  if let certificate = NCPreferences().getEndToEndCertificate(account: account) {
    result = NCEndToEndEncryption.shared().verifyCertificate(certificate, publicKey: publicKey)
  }

  if result == false {
    let error = NKError(
      errorCode: NCGlobal.shared.errorInternalError,
      errorDescription: "Serious internal error to verify certificate")
    NCContentPresenter().messageNotification(
      "E2E verify certificate server", error: error, delay: NCGlobal.shared.dismissAfterSecond,
      type: NCContentPresenter.messageType.error, priority: .max)
  }

  return result
}

Usage in createNewE2EE and getPrivateKeyCipher.:

if error == .success, let publicKey {
  let verifyCertificate = self.verifyCertificate(account, publicKey)
  if !verifyCertificate {
    return
  }

  NCPreferences().setEndToEndPublicKey(account: account, publicKey: publicKey)
  NCManageDatabase.shared.clearTablesE2EE(account: account)

  self.delegate?.endToEndInitializeSuccess(metadata: self.metadata)

}

[marinofaggiana]

Thanks for your suggestion but this class needs to be totally rewritten in asyn when I have time