Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the initialization of FileNameValidator and FileAutoRenamer to use a simplified constructor that accepts the entire capabilities object instead of individual capability properties.
- Simplified
FileNameValidatorinitialization from passing four separate capability properties to passing a singlecapabilitiesobject - Simplified
FileAutoRenamerinitialization from passing two separate capability properties to passing a singlecapabilitiesobject
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| iOSClient/Utility/FileNameValidator+Extensions.swift | Updated checkFileName and checkFolderPath methods to use simplified FileNameValidator constructor with capabilities object |
| iOSClient/Utility/FileAutoRenamer+Extensions.swift | Updated rename method to use simplified FileAutoRenamer constructor with capabilities object |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marinofaggiana
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite: nextcloud/NextcloudKit#201 (review)