Update download limit only when changed by user#3899
Merged
Conversation
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the download limit update logic by adding a flag to track whether the download limit was explicitly changed by the user. This prevents unnecessary API calls to update the download limit when the user saves share settings without modifying the download limit.
Key changes:
- Added a
changeDownloadLimitparameter to theupdateSharemethod to conditionally update download limits - Introduced a
downloadLimitChangedflag inNCShareAdvancePermissionto track user modifications - Modified the conditional logic to only update download limits when explicitly changed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| iOSClient/Share/NCShareNetworking.swift | Added changeDownloadLimit parameter to updateShare method and updated conditional logic to check this flag before updating download limits |
| iOSClient/Share/Advanced/NCShareAdvancePermission.swift | Added downloadLimitChanged flag and set it to true in the delegate method when user changes download limit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
marinofaggiana
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before download limit would always update when a share changes, resetting the download counter. Now it resets only when changed by user.