Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues in the QuickLook viewer for scanned documents. First, it resolves a crash that occurred when sharing or downloading photos while in draw mode by using copyFile instead of moveFile (preventing iOS from losing the file reference). Second, it addresses a timing issue where draw edits weren't being saved properly by refactoring the dismiss flow to show the save alert after the view controller dismisses, giving more time for QuickLook's didSaveEditedCopyOf callback to complete.
Key Changes:
- Changed file operation from
moveFiletocopyFileindidSaveEditedCopyOfto prevent iOS file reference loss - Refactored alert presentation logic into separate
showSaveAlert()method - Modified
dismissViewto show save alert in dismiss completion handler rather than before dismissing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marinofaggiana
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where trying to share or download the photo while in draw mode will cause a crash.
- Issue occurs because we
moveFileto a new location instead ofcopyFile. iOS cannot find the original location of the file, causing a crash.Fixes issue where a draw edit will not be saved properly and will be reset.
- Happened because
saveModifiedFileis called beforedidSaveEditedCopyOf, ignoring the changes.