Conversation
|
Looks good and works as before 👍 |
|
👍 |
|
seem mysql is not happy. I'll have a look tomorrow |
So this is a BC breaking minor update... great 🎉
I guess we need to fix the schema reader and hack it in. We can't break all these apps on 5.6 + mysql (I guess this is the greatest part of instances) |
|
Mmm I must say I'm surprised this even worked before. But the big question is why did it work before and not anymore. |
|
Ok so it fails now because of: https://github.com/nextcloud/3rdparty/pull/18/files#diff-f1134e2d70bff8e3d0e698f41c3a652bL111 Which is a line added by @MorrisJobke in doctrine/dbal@e73ef8b But has no trace in the 2.5 branch aparently anymore. |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
1ae353e to
b1641cc
Compare
|
Pushed 3rdparty patch lets see |
|
Whee mysql is happy. |
|
👍 |
|
Upps .. 3rdparty needs to be updated to current master -> @rullzer could you update this? |
Requires: nextcloud/3rdparty#18
With test fixes from owncloud/core#26085
CC: @nickvergessen @MorrisJobke @LukasReschke @icewind1991