chore : Comprehensive e2e testing for public sharing#50260
Merged
Conversation
nfebe
force-pushed
the
enhancements/files-sharing-tests
branch
4 times, most recently
from
088f24e to
2133889
Compare
nfebe
changed the title
nfebe
changed the title
susnux
reviewed
Jan 20, 2025
artonge
reviewed
Jan 21, 2025
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Feels like the missing piece is now to ensure that the submitted share options are effective by accessing the share.
cypress/e2e/files_sharing/public-share/required-before-create.cy.ts
Outdated
Show resolved
Hide resolved
8 tasks
nfebe
force-pushed
the
enhancements/files-sharing-tests
branch
2 times, most recently
from
4b32508 to
96b7fdb
Compare
nfebe
force-pushed
the
enhancements/files-sharing-tests
branch
from
96b7fdb to
3b0ee61
Compare
Contributor
Author
|
/compile |
artonge
approved these changes
Feb 3, 2025
This update enhances the testing framework for public sharing by improving the setup and management of share contexts. It refactors the code to make the `createShare` function reusable externally, ensuring better testability and flexibility. Additionally, the update optimizes share permission adjustments and improves state management, making public share setups more efficient and maintainable. Signed-off-by: nfebe <fenn25.fn@gmail.com>
This commit introduces end-to-end tests for various public link sharing scenarios in the `files_sharing` app. It validates the behavior under multiple configurations: - Password and expiration date enforced - Password enforced with a default expiration date - Expiration date enforced with optional password - Default password and expiration date without enforcement - Password enforced, expiration date set but not enforced - Both password and expiration date not enforced, but defaults set - Password not enforced, expiration date enforced - Password not enforced, default expiration date set - Password and expiration date not enforced with no defaults The tests ensure proper validation and functionality of the configurations, leveraging the `setupData` and `createShare` utilities. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
force-pushed
the
enhancements/files-sharing-tests
branch
from
c3b8d2c to
6d37e16
Compare
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
This was referenced Feb 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the testing framework for public sharing by introducing modular improvements and extending test coverage with "before create public share" checks.
Adds the following tests:
Screencast for e2e plays
public-sharing-e2e-tests.mp4