refactor(updatenotification): cleanup and remove deprecated usage#52669
Merged
provokateurin merged 6 commits intomasterfrom May 14, 2025
Merged
refactor(updatenotification): cleanup and remove deprecated usage#52669provokateurin merged 6 commits intomasterfrom
provokateurin merged 6 commits intomasterfrom
Conversation
susnux
added
the
♻️ refactor
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Please adjust the tests in the commits where they need to be changed, not afterwards. Otherwise bisecting will be more painful than necessary.
come-nc
reviewed
May 13, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…lass members Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This is already included since Nextcloud 29, so the background job is removed and the class does not exist anymore. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/refactor-update-notification+
branch
from
89c944c to
76696be
Compare
Contributor
Author
done |
come-nc
approved these changes
May 13, 2025
provokateurin
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist