Merged
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
bcf56cb to
1609d35
Compare
susnux
reviewed
Jun 2, 2025
| codecovWebpackPlugin({ | ||
| enableBundleAnalysis: !isDev && !isTesting, | ||
| bundleName: 'nextcloud', | ||
| telemetry: false, |
Contributor
There was a problem hiding this comment.
Alternative:
Suggested change
| telemetry: false, | |
| telemetry: !!process.env.CI, |
Contributor
Author
There was a problem hiding this comment.
I do not have a strong opinion on this. Are you aware that telemetry data is unrelated to bundle analytics and is solely about collecting data? Or do you see anything in Requests 1 and 2 that looks related to the bundle analytics?
Contributor
There was a problem hiding this comment.
Hey again from Codecov! You're correct that telemetry is just for our internal usage metrics/error reporting/etc. It won't affect the functionality to disable telemetry. Let me know if you folks have any further questions about anything 🙂
skjnldsv
approved these changes
Jun 6, 2025
Member
skjnldsv
left a comment
There was a problem hiding this comment.
Good from me whatever the decision
spalmurray
approved these changes
Jun 9, 2025
susnux
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#52179 enabled Codecov's test and bundle analytics.
This pull request only disables the telemetry. I just want to raise awareness about it and raise the question: do we really need it?
When running npm run build, as we do for building the production assets, the webpack plugin is active and communicates externally.
Telemetry is responsible for two requests to api.codecov.com. These requests do not contain sensitive data; they appear to be a check-in and check-out for the build process.
Request 1
{ "event_id": "063a21a232cf4a19a2e0d00ef47355d0", "sent_at": "2025-06-01T21:13:49.626Z", "trace": { "environment": "production", "release": "1.9.0", "public_key": "942e283ea612c29cc3371c6d27f57e58", "trace_id": "3d5c39eb83094814a9fb9d2780e07398", "sample_rate": "1", "transaction": "Codecov Bundler Plugin Execution", "sampled": "true" } } { "type": "transaction" } { "contexts": { "trace": { "span_id": "88f72767334ca4ba", "trace_id": "3d5c39eb83094814a9fb9d2780e07398", "data": { "sentry.origin": "manual", "sentry.op": "bundler-plugin-execution", "sentry.source": "custom", "sentry.sample_rate": 1 }, "op": "bundler-plugin-execution", "origin": "manual" }, "runtime": { "name": "node", "version": "v22.15.1" } }, "spans": [], "start_timestamp": 1748812429.623899, "timestamp": 1748812429.6243742, "transaction": "Codecov Bundler Plugin Execution", "type": "transaction", "transaction_info": { "source": "custom" }, "platform": "node", "event_id": "063a21a232cf4a19a2e0d00ef47355d0", "environment": "production", "release": "1.9.0", "tags": { "node": "v22.15.1", "platform": "linux", "plugin.name": "@codecov/webpack-plugin", "plugin.version": "1.9.0", "auth_mode": "tokenless", "ci": false, "meta_framework": "none", "bundler": "webpack" } }Request 2
{ "event_id": "e96e4e58200b43508570c9126421ba80", "sent_at": "2025-06-01T21:14:38.347Z", "trace": { "environment": "production", "release": "1.9.0", "public_key": "942e283ea612c29cc3371c6d27f57e58", "trace_id": "3d5c39eb83094814a9fb9d2780e07398", "sample_rate": "1", "transaction": "Codecov Bundler Plugin Execution", "sampled": "true" } } { "type": "transaction" } { "contexts": { "trace": { "parent_span_id": "88f72767334ca4ba", "span_id": "802b96226619e273", "trace_id": "3d5c39eb83094814a9fb9d2780e07398", "data": { "sentry.origin": "manual", "sentry.op": "output.write", "sentry.source": "custom", "sentry.sample_rate": 1 }, "op": "output.write", "origin": "manual" }, "runtime": { "name": "node", "version": "v22.15.1" } }, "spans": [ { "data": { "sentry.origin": "manual", "sentry.op": "output.write.detectProvider" }, "description": "Detect Provider", "op": "output.write.detectProvider", "parent_span_id": "802b96226619e273", "span_id": "bd932a531d2cd00a", "start_timestamp": 1748812471.393833, "timestamp": 1748812471.483911, "trace_id": "3d5c39eb83094814a9fb9d2780e07398", "origin": "manual" }, { "data": { "sentry.origin": "manual", "sentry.op": "output.write.getPreSignedURL" }, "description": "Get Pre-Signed URL", "op": "output.write.getPreSignedURL", "parent_span_id": "802b96226619e273", "span_id": "af5024bb099b671d", "start_timestamp": 1748812471.4842181, "timestamp": 1748812471.9964101, "trace_id": "3d5c39eb83094814a9fb9d2780e07398", "origin": "manual" }, { "data": { "sentry.origin": "manual", "sentry.op": "http.client", "http.request.method": "POST", "http.request.url": "https://api.codecov.io/upload/bundle_analysis/v1", "http.response.status_code": 202, "http.response_content_length": 440, "http.response.status_text": "Accepted" }, "description": "Fetching Pre-Signed URL", "op": "http.client", "parent_span_id": "af5024bb099b671d", "span_id": "9a48679f9dbf1804", "start_timestamp": 1748812471.530388, "timestamp": 1748812471.994159, "trace_id": "3d5c39eb83094814a9fb9d2780e07398", "origin": "manual" }, { "data": { "sentry.origin": "manual", "sentry.op": "output.write.uploadStats" }, "description": "Upload Stats", "op": "output.write.uploadStats", "parent_span_id": "802b96226619e273", "span_id": "b1b8d8a5d3e560de", "start_timestamp": 1748812471.9965694, "timestamp": 1748812478.343116, "trace_id": "3d5c39eb83094814a9fb9d2780e07398", "origin": "manual" }, { "data": { "sentry.origin": "manual", "sentry.op": "http.client", "http.request.method": "PUT", "http.response.status_code": 200, "http.response_content_length": 0, "http.response.status_text": "OK" }, "description": "Uploading Stats", "op": "http.client", "parent_span_id": "b1b8d8a5d3e560de", "span_id": "82872b3486ddf1cc", "start_timestamp": 1748812472.0020504, "timestamp": 1748812478.3429804, "trace_id": "3d5c39eb83094814a9fb9d2780e07398", "origin": "manual" } ], "start_timestamp": 1748812471.3934011, "timestamp": 1748812478.3438063, "transaction": "Output Write", "type": "transaction", "transaction_info": { "source": "custom" }, "platform": "node", "event_id": "e96e4e58200b43508570c9126421ba80", "environment": "production", "release": "1.9.0", "tags": { "node": "v22.15.1", "platform": "linux", "plugin.name": "@codecov/webpack-plugin", "plugin.version": "1.9.0", "auth_mode": "tokenless", "ci": false, "meta_framework": "none", "bundler": "webpack", "service": "local", "owner": "nextcloud", "repo": "server" } }Is sending two requests to the Google Storage service, uploading data about the bundle. Since we do not compile the assets on CI, I assume it is necessary to do it locally. However, I am not particularly in favor of every local build now uploading data to Codecov. Given the limited use of this feature, I would prefer to disable it again.
Request 3
{ "branch": "bug/53243/wrong-app-id-for-systemtags-settings", "build": null, "buildURL": null, "commit": "ffe5caa91b9f56e98f98a968d87eefa1991dfac2", "job": null, "pr": null, "service": "local", "slug": "nextcloud::::server", "git_service": "github" }Request 4
Note: I emptied assets, chunks and modules.
{ "version": "3", "builtAt": 1748812429646, "duration": 41714, "bundleName": "nextcloud-array-push", "outputPath": "/path/to/the/working/directory", "bundler": { "name": "webpack", "version": "5.99.9" }, "plugin": { "name": "@codecov/webpack-plugin", "version": "1.9.0" }, "assets": [], "chunks": [], "modules": [] }Checklist