feat(ocp): add email address validator

[kesselb]

Summary

Makes it possible to validate an email address, without injecting the mailer.

Todo

• Step through testSetUserSettings to ensure everything's working as before

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

This was already deprecated since 26 we undeprecated it for 32 but if you add a replacement, please readd the deprecation since 26.

[susnux]

Code looks good, my comment about the deprecation is still valid

[kesselb]

Code looks good, my comment about the deprecation is still valid

I only change the interface 🙈

[kesselb]

What do you think about the trait to obtain an instance for usage in tests?

[kesselb]

The tests are now using the preconfigured instance from the trait. I think it’s a plus that the validation is now done with the actual implementation and not a test double. The downside is that we’re losing the check that the validator was called.

[kesselb]

Moved the refactoring commits, to use the validator, to another branch because it's external API freeze today, and checking the test needs more time.

[susnux]

Moved the refactoring commits, to use the validator, to another branch because it's external API freeze today, and checking the test needs more time.

But that does not change anything here, no? We do not remove the old way and just refactor internal usage.

[kesselb]

But that does not change anything here, no? We do not remove the old way and just refactor internal usage.

Fair enough, technically we do not break anything and just add a new API. I'm running a bit out of time this week and thus wanted to make sure that the new API lands in 32. There was a conflicting merge meanwhile, and also one of the tests needs a closer look (if we are still testing the right thing). I hope to finish it next week and have everything migrated for 32.

Okay for you to merge this one without the refactorings, or do you want to keep it together?

[susnux]

Its fine.
Maybe you have time to do so after branch off?