Skip to content

Comments

chore: update @nextcloud/vue to v8.29.1 for beta of Nextcloud 32#54497

Merged
skjnldsv merged 8 commits intomasterfrom
chore/update-nextcloud-vue-8-29
Aug 19, 2025
Merged

chore: update @nextcloud/vue to v8.29.1 for beta of Nextcloud 32#54497
skjnldsv merged 8 commits intomasterfrom
chore/update-nextcloud-vue-8-29

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Aug 18, 2025

Summary

Update for fixing status colored buttons.

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Aug 18, 2025
@susnux susnux requested a review from a team as a code owner August 18, 2025 23:07
@susnux susnux added the 3. to review Waiting for reviews label Aug 18, 2025
@susnux susnux requested a review from a team as a code owner August 18, 2025 23:07
@susnux susnux requested review from CarlSchwan, nfebe, skjnldsv and szaimen and removed request for a team and nfebe August 18, 2025 23:07
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

CI failure might be related?

@AndyScherzinger
Copy link
Member

/compile rebase

@nextcloud-command nextcloud-command force-pushed the chore/update-nextcloud-vue-8-29 branch from 1d0e820 to 9014dc0 Compare August 19, 2025 07:01
@susnux susnux force-pushed the chore/update-nextcloud-vue-8-29 branch from 9014dc0 to 0487b88 Compare August 19, 2025 08:14
@susnux
Copy link
Contributor Author

susnux commented Aug 19, 2025

CI failure might be related?

Yes but only because we were not mocking the state of OC.config to provide the Nextcloud version (used to determine which design to use for components).

@susnux susnux force-pushed the chore/update-nextcloud-vue-8-29 branch from eca5eb4 to 16b5f19 Compare August 19, 2025 10:35
@skjnldsv
Copy link
Member

> Cannot read properties of undefined (reading 'split')

When Cypress detects uncaught errors originating from your application it will automatically fail the current test.

This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event.

https://on.cypress.io/uncaught-exception-from-application
      at 77056 (http://localhost:8083/dist/core-common.js?v=ba222ded25d957b900c03bef9[143](https://github.com/nextcloud/server/actions/runs/17067018515/job/48393835718?pr=54497#step:7:144)33cd:1:3381157)
      at a (http://localhost:8083/dist/core-main.js?v=ba222ded25d957b900c03bef914333cd:1:1020547)
      at 40741 (http://localhost:8083/dist/core-common.js?v=ba222ded25d957b900c03bef914333cd:1:2260308)
      at a (http://localhost:8083/dist/core-main.js?v=ba222ded25d957b900c03bef914333cd:1:1020547)
      at 41944 (http://localhost:8083/dist/core-common.js?v=ba222ded25d957b900c03bef914333cd:1:2280685)
      at a (http://localhost:8083/dist/core-main.js?v=ba222ded25d957b900c03bef914333cd:1:1020547)
      at 4529 (http://localhost:8083/dist/core-main.js?v=ba222ded25d957b900c03bef914333cd:1:167222)
      at a (http://localhost:8083/dist/core-main.js?v=ba222ded25d957b900c03bef914333cd:1:1020547)
      at <unknown> (http://localhost:8083/dist/core-main.js?v=ba222ded25d957b900c03bef914333cd:1:1023927)
      at a.O (http://localhost:8083/dist/core-main.js?v=ba222ded25d957b900c03bef914333cd:1:1020847)

@skjnldsv
Copy link
Member

image

@skjnldsv
Copy link
Member

@susnux
Copy link
Contributor Author

susnux commented Aug 19, 2025

image

Yes needed to have proper mocks

@susnux susnux force-pushed the chore/update-nextcloud-vue-8-29 branch from 16b5f19 to fd232f2 Compare August 19, 2025 12:34
@skjnldsv
Copy link
Member

Yes needed to have proper mocks

This is runtime setup.
Why would we need mock here 🙈

@susnux
Copy link
Contributor Author

susnux commented Aug 19, 2025

This is runtime setup.

You are right we use the components outside of Nextcloud context here - OC is not available if not installed!
Nice catch!

@skjnldsv skjnldsv changed the title chore: update @nextcloud/vue to v8.29.0 for beta of Nextcloud 32 chore: update @nextcloud/vue to v8.29.1 for beta of Nextcloud 32 Aug 19, 2025
@skjnldsv
Copy link
Member

/compile rebase

@skjnldsv skjnldsv enabled auto-merge August 19, 2025 15:04
@nextcloud-command nextcloud-command force-pushed the chore/update-nextcloud-vue-8-29 branch from 96111bc to 5b69b5a Compare August 19, 2025 15:10
@skjnldsv skjnldsv force-pushed the chore/update-nextcloud-vue-8-29 branch from 5b69b5a to 9803e80 Compare August 19, 2025 15:13
@skjnldsv
Copy link
Member

skjnldsv commented Aug 19, 2025

image

(╯°□°)╯︵ ┻━┻

nextcloud-libraries/nextcloud-vue#7320

@susnux
Copy link
Contributor Author

susnux commented Aug 19, 2025

@susnux susnux force-pushed the chore/update-nextcloud-vue-8-29 branch from 9803e80 to 8e4988e Compare August 19, 2025 15:42
@susnux susnux requested a review from a team as a code owner August 19, 2025 15:42
@susnux susnux requested review from nfebe and provokateurin and removed request for a team August 19, 2025 15:42
@skjnldsv
Copy link
Member

/compile rebase

@skjnldsv skjnldsv disabled auto-merge August 19, 2025 15:52
susnux and others added 6 commits August 19, 2025 16:01
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
Copy link
Contributor Author

susnux commented Aug 19, 2025

@skjnldsv runner tests work but the unit tests for DAV needs updating after bumping the vue version (npm run test:update-snapshots)

@skjnldsv
Copy link
Member

Saw it after the rebase request, waiting for the push and I'll rebase

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the chore/update-nextcloud-vue-8-29 branch from 8e4988e to 4102af5 Compare August 19, 2025 16:04
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 3cacd7c into master Aug 19, 2025
212 of 216 checks passed
@skjnldsv skjnldsv deleted the chore/update-nextcloud-vue-8-29 branch August 19, 2025 16:23
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants