Fix type and other psalm issues in lib/private/Template#55404
Merged
Fix type and other psalm issues in lib/private/Template#55404
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
The implementation supports passing null and our code is using that, reflect it in the public API. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
CarlSchwan
approved these changes
Sep 29, 2025
come-nc
added
2. developing
come-nc
force-pushed
the
fix/cleanup-resource-locators
branch
from
3d51d0a to
ccb0d17
Compare
icewind1991
approved these changes
Sep 29, 2025
provokateurin
approved these changes
Sep 30, 2025
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/cleanup-resource-locators
branch
from
ccb0d17 to
bdff123
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup typing, run rector, fix psalm issues, and move away from deprecated methods in lib/private/Template folder.
Checklist
3. to review, feature component)stable32)