Merged
Conversation
ArtificialOwl
force-pushed
the
fix/noid/ocm-value-format
branch
from
8cbf207 to
5e52d21
Compare
mickenordin
reviewed
Oct 8, 2025
mickenordin
force-pushed
the
fix/noid/ocm-value-format
branch
3 times, most recently
from
c622926 to
a777cc5
Compare
ArtificialOwl
force-pushed
the
fix/noid/ocm-value-format
branch
from
a777cc5 to
6b515a4
Compare
ArtificialOwl
requested review from
Altahrim,
CarlSchwan and
yemkareems
and removed request for
a team
CarlSchwan
approved these changes
Oct 13, 2025
nickvergessen
previously requested changes
Oct 13, 2025
ArtificialOwl
force-pushed
the
fix/noid/ocm-value-format
branch
from
6b515a4 to
c0f900e
Compare
Member
Author
|
@mickenordin let's have a first PR regarding we'll check in the future if 'shareWith' is to be modified |
mickenordin
force-pushed
the
fix/noid/ocm-value-format
branch
from
c0f900e to
5c3ffed
Compare
Contributor
|
Lets go with what is currently here and worry about the rest later on |
Member
Author
|
/backport to stable32 |
nickvergessen
dismissed
their stale review
Obsoleted by removing problematic parts
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/ocm-value-format
branch
from
5c3ffed to
b2a6c75
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shareWithcontaining scheme of the remote instanceproviderIdto be a string when generating json