Port away from deprecated Doctrine APIs#55674
Merged
CarlSchwan merged 4 commits intomasterfrom Oct 13, 2025
Merged
Conversation
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
Instead use Type::lookupName Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
force-pushed
the
carl/deprecated-dbal
branch
2 times, most recently
from
977f88c to
5e5e075
Compare
CarlSchwan
requested review from
a team,
ChristophWurst,
SebastianKrupinski,
hamza221,
miaulalala,
nickvergessen,
st3iny and
tcitworld
as code owners
CarlSchwan
requested review from
ArtificialOwl,
provokateurin and
salmart-dev
and removed request for
a team
ChristophWurst
approved these changes
Oct 13, 2025
provokateurin
approved these changes
Oct 13, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Very nice, but I think you need to run cs:fix on the 3rd commit, as some of the imports are only removed in the 4th commit where they don't belong.
Use getDatabaseProvider instead. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
CarlSchwan
force-pushed
the
carl/deprecated-dbal
branch
from
5e5e075 to
49d5227
Compare
susnux
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all calls to the following APIs:
IQueryBuilder::executeTable::hasPrimaryKeyType::getNameAnd from the following pattern:
getDatabasePlatform() instanceofChecklist
3. to review, feature component)stable32)