Conversation
…interactive mode Signed-off-by: yemkareems <yemkareems@gmail.com>
artonge
left a comment
There was a problem hiding this comment.
That's going in the good direction :).
Don't forget the other question that comes later.
…run encryption non-interactive only when -n option is present Signed-off-by: yemkareems <yemkareems@gmail.com>
artonge
left a comment
There was a problem hiding this comment.
There is also that question:
server/apps/encryption/lib/Crypto/EncryptAll.php
Lines 281 to 285 in f6fe536
…non-interactive mode sent the password directly Signed-off-by: yemkareems <yemkareems@gmail.com>
come-nc
left a comment
There was a problem hiding this comment.
The option --no-interaction is provided by symfony for all console commands.
So the only thing you need to do is to remove the warning to prevent non-interactive input. Ideally make sure to only remove the warning if the option is passed.
…ault answer to both questions true to support -n run directly Signed-off-by: yemkareems <yemkareems@gmail.com>
artonge
left a comment
There was a problem hiding this comment.
Looks good beside nitpick
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
possible options now are
occ encryption:encrypt-all
will ask the confirmation question before proceeding with encryption
occ encryption:encrypt-all -n
will not ask the question and run the encryption directly
Summary
TODO
Checklist
3. to review, feature component)stable32)