fix(user_ldap): Do not use variables directly in translation strings#56728
Merged
AndyScherzinger merged 1 commit intomasterfrom Dec 2, 2025
Merged
Conversation
come-nc
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
yemkareems
and removed request for
a team
rakekniven
approved these changes
Nov 27, 2025
I simply removed translations for exceptions which are never supposed to happen apart from API misuse or code bug. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-wizard-controller-translation-string
branch
from
e70b89e to
7eefd72
Compare
AndyScherzinger
approved these changes
Dec 2, 2025
AndyScherzinger
deleted the
fix/fix-wizard-controller-translation-string
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I simply removed translations for exceptions which are never supposed to
happen apart from API misuse or code bug.
Checklist
3. to review, feature component)stable32)