chore: update @nextcloud/files to 4.0.0-beta.4#56743
Merged
Conversation
skjnldsv
requested review from
artonge and
susnux
and removed request for
a team
susnux
reviewed
Nov 28, 2025
skjnldsv
force-pushed
the
chore/files-4-0-0
branch
8 times, most recently
from
4fa769e to
92ef012
Compare
skjnldsv
force-pushed
the
chore/files-4-0-0
branch
2 times, most recently
from
e95ea13 to
390e6c3
Compare
skjnldsv
force-pushed
the
chore/files-4-0-0
branch
from
390e6c3 to
9c5c863
Compare
skjnldsv
added
3. to review
Member
Author
|
Finally done!! 😩 |
skjnldsv
added
the
♻️ refactor
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
chore/files-4-0-0
branch
from
9c5c863 to
7aa6a74
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
susnux
changed the title
@nextcloud/files to 4.0.0@nextcloud/files to 4.0.0-beta.4
susnux
reviewed
Dec 11, 2025
| // then browse its tree and upload its contents. | ||
| if (file instanceof Directory) { | ||
| const absolutePath = joinPaths(davRootPath, destination.path, relativePath) | ||
| const absolutePath = joinPaths(getRootPath(), destination.path, relativePath) |
Contributor
There was a problem hiding this comment.
could also be just defaultRootPath
susnux
reviewed
Dec 11, 2025
| id: 0, | ||
| source: `${davRemoteURL}${davRootPath}`, | ||
| root: davRootPath, | ||
| source: `${getRemoteURL()}${getRootPath()}`, |
Contributor
There was a problem hiding this comment.
same here we could in general use the cached variant. But not that important.
susnux
reviewed
Dec 11, 2025
| }, | ||
| }) | ||
|
|
||
| page.debug() |
Member
Author
There was a problem hiding this comment.
I was soooo annoyed by this lol
I forgot I removed it here 😁
susnux
approved these changes
Dec 11, 2025
CarlSchwan
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easier review PR: #57003
Includes/needs
Node.roota required attribute nextcloud-libraries/nextcloud-files#1388isDavRessourcenextcloud-libraries/nextcloud-files#1390