feat(userList): Allow to list all users#57179
Conversation
77748c1 to
b585280
Compare
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
miaulalala
left a comment
There was a problem hiding this comment.
What's the highest amount of users you've tested this with? I'm a bit worried about running out of memory - I think it would be wise to chunk the output to something like 500 or 1000 users per call to writeArrayInOutputFormat
|
@miaulalala You would still have all users in memory, no? |
11.768 in a public instance (using LDAP). |
|
Also please note that this PR is not different from something like |
--limit 0to disableuser:listlimit #57120Summary
Updated the limit option to allow
--limit=0for unlimited users listing.This PR simply passes null to underlying methods since
IUserManager::searchDisplayName()andIUserManager::getDisabledUsers()acceptnullfor the limit parameter.Checklist
3. to review, feature component)stable32)