Skip to content

Comments

chore(cleanup): webpackChunkNames#7630

Merged
max-nextcloud merged 1 commit intomainfrom
cleanup/webpackChunkName
Sep 13, 2025
Merged

chore(cleanup): webpackChunkNames#7630
max-nextcloud merged 1 commit intomainfrom
cleanup/webpackChunkName

Conversation

@max-nextcloud
Copy link
Collaborator

We use vite now.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.92%. Comparing base (3196a7a) to head (fa64ebd).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/editor.js 0.00% 2 Missing ⚠️
src/EditorFactory.js 0.00% 1 Missing ⚠️
src/components/Editor.singleton.js 0.00% 1 Missing ⚠️
src/components/PublicFilesEditor.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7630   +/-   ##
=======================================
  Coverage   52.92%   52.92%           
=======================================
  Files         503      503           
  Lines       43803    43799    -4     
  Branches     1129     1129           
=======================================
- Hits        23184    23182    -2     
+ Misses      20510    20508    -2     
  Partials      109      109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the prettier failure.

@max-nextcloud max-nextcloud force-pushed the cleanup/webpackChunkName branch from 27c32f2 to 4841f2b Compare September 13, 2025 13:53
We use vite now.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud force-pushed the cleanup/webpackChunkName branch from 4841f2b to fa64ebd Compare September 13, 2025 14:05
@max-nextcloud max-nextcloud merged commit c18a8b7 into main Sep 13, 2025
65 of 66 checks passed
@max-nextcloud max-nextcloud deleted the cleanup/webpackChunkName branch September 13, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants