Skip to content

Comments

chore(migrate): scss use @use instead of @import#7782

Merged
juliusknorr merged 1 commit intomainfrom
fix/use-css-not-import
Oct 14, 2025
Merged

chore(migrate): scss use @use instead of @import#7782
juliusknorr merged 1 commit intomainfrom
fix/use-css-not-import

Conversation

@max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Oct 14, 2025

Gets rid of the deprecation warning.

@use is per file / style block.
I.e. it is not possible to nest it inside a css selector
like we did in Editor.vue.
However I think our css is specific enough to not apply outside the editor anyway.

@use is per file / style block.|
I.e. it is not possible to nest it inside a css selector
like we did in Editor.vue.
However I think our css is specific enough to not apply outside the editor anyway.

Signed-off-by: Max <max@nextcloud.com>
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.19%. Comparing base (c358bdf) to head (b58afe0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7782      +/-   ##
==========================================
- Coverage   60.19%   60.19%   -0.01%     
==========================================
  Files         502      502              
  Lines       38562    38561       -1     
  Branches     1135     1135              
==========================================
- Hits        23211    23210       -1     
  Misses      15245    15245              
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliusknorr juliusknorr merged commit 5bda258 into main Oct 14, 2025
74 of 77 checks passed
@juliusknorr juliusknorr deleted the fix/use-css-not-import branch October 14, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants